chore: optionally add organization logo via lfx serve api (CM-1102)#4008
Merged
joanagmaia merged 4 commits intomainfrom Apr 8, 2026
Merged
chore: optionally add organization logo via lfx serve api (CM-1102)#4008joanagmaia merged 4 commits intomainfrom
joanagmaia merged 4 commits intomainfrom
Conversation
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for passing an optional organization logo during public API organization creation, and introduces LFX_SERVE as a recognized organization attribute source with defined precedence.
Changes:
- Added
LFX_SERVEtoOrganizationAttributeSource. - Included
LFX_SERVEinORG_DB_ATTRIBUTE_SOURCE_PRIORITY. - Extended the public
createOrganizationendpoint to accept and forward an optionallogo, and include it in the response.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/libs/types/src/enums/organizations.ts | Adds LFX_SERVE to the organization attribute source enum. |
| services/libs/data-access-layer/src/organizations/attributesConfig.ts | Adds LFX_SERVE into the attribute source priority list. |
| backend/src/api/public/v1/organizations/createOrganization.ts | Accepts optional logo, uses LFX_SERVE as the org source, and returns logo in the response. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
…rganization-logo Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
skwowet
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for an optional organization logo in the organization creation API and updates the handling of organization attribute sources to include
LFX_SERVE. The changes ensure that the logo can be provided when creating an organization and that the new attribute source is recognized throughout the system.API changes:
logofield to thecreateOrganizationAPI request body schema and response, allowing clients to specify a logo when creating an organization. [1] [2]Attribute source updates:
LFX_SERVEas a new value to theOrganizationAttributeSourceenum, enabling it as a valid source for organization attributes.ORG_DB_ATTRIBUTE_SOURCE_PRIORITYarray to includeLFX_SERVE, ensuring it is considered when determining attribute precedence.Note
Medium Risk
Introduces a new organization attribute source and changes attribute source priority, which can alter which data wins during org attribute resolution; also expands the public create-org API surface area.
Overview
The public
createOrganizationendpoint now accepts an optionallogo, passes it through tofindOrCreateOrganization, and includes it in the creation response.Organization creation via this endpoint is re-sourced from
CUSTOMto the newOrganizationAttributeSource.LFX_SERVE, and the types + attribute-source priority list are updated to recognizeLFX_SERVEahead of enrichment sources when resolving organization attributes.Reviewed by Cursor Bugbot for commit 5750de3. Bugbot is set up for automated code reviews on this repo. Configure here.